Adds default values for section#153
Closed
mrzarquon wants to merge 3 commits intopuppetlabs:masterfrom
Closed
Conversation
Our documentation says to use "" for section if you want top of file global settings, this defaults to that assumption if the user doesn't provide a section parameter at all.
Contributor
|
Could you update the README as well? |
Contributor
There was a problem hiding this comment.
Could you actually say that it 'Defaults to ""' like the other parameters say?
Contributor
|
Ping @mrzarquon. Thanks for the contribution. The fix looks good. However can you make a few updates?
Same applies to the subsetting definition.
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our documentation says to use "" for section if you want top of file
global settings, this defaults to that assumption if the user doesn't
provide a section parameter at all.